Preserve native sample rate, don't auto-resample to 22050#849
Open
tombagby wants to merge 4 commits into
Open
Conversation
The default in librosa is sr=22050, which forces resampling, it has to be set explicitly to None to preserve the original sample rate. I doubt this is intentional? If resampling is desired, the field description should include an explicit target sample rate to enable.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Author
|
recheck |
Contributor
|
Hi @tombagby , thank you for your contribution! I think you'd need to ru: to update the test outputs, which should hopefully fix the failing tests. |
Contributor
Contributor
|
Uhm, I thought that the change in this PR would also affect the output records? In any case, I rerun the CI tests and there still are errors: https://github.com/mlcommons/croissant/actions/runs/14850204797/job/41806335710?pr=849 |
Contributor
|
@ccl-core You're right. It could work with other PRs but not this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default in librosa is sr=22050, which forces resampling, it has to be set explicitly to None to preserve the original sample rate. I doubt this is intentional?
If resampling is desired, the field description should support an explicit target sample rate to enable.